Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

specs a bit refactored & updated to support 1.9.3 as well as 1.8.7 #5

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

hubertlepicki commented Mar 21, 2013

specs were failing for me on 1.9.3 because of FSPath and nitems() usage. Have refactored it not to use the 2 dependencies.

Added Gemfile so we can just 'bundle' to install dependencies.

All but audio tests are passing on 1.9.3 and 1.8.7.

Audio tests are throwing: function ph_readaudio not found [libpHash.so] but I suspect my installation of pHash being not complete (stock Ubuntu 12.10 universe).

On JRuby, also text similarity tests are failing (undefined method 'free' for FFI::Pointer) but I intend to fix it another time.

Owner

toy commented Mar 23, 2013

I've fixed freeing memory in specs_fixes branch. Though can't make video hashing to work — Segmentation fault, but it seems to be problem in pHash library or FFmpeg as test bins in pHash gives me same.
Why did you add Bundler.require to spec_helper? You can run bundler exec rspec spec instead of rspec spec to get dependencies through bundler.

Owner

toy commented Sep 6, 2013

Merged

@toy toy closed this Sep 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment