-
-
Notifications
You must be signed in to change notification settings - Fork 6
fix napi_async_work
prevent Node.js from exiting
#26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
emnapi worker pool size in test is too great |
The worker ref/unref logic here seems a bit complicated TBH, especially with various checks, Node.js doesn't care which handle keeps the process alive, so you don't need to From worker side, it should be enough to only |
Done. |
Nice, looks much simpler! |
By the way, I wanted to ask - why did you need |
This is for backward compatibility, I remember emscripten once refactored |
fixes #25