Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale invariance and bounds checking #44

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Add scale invariance and bounds checking #44

merged 1 commit into from
Mar 30, 2021

Conversation

Rupt
Copy link
Collaborator

@Rupt Rupt commented Mar 30, 2021

Teach mt2_bisect_impl to divide out the scale to give bigger dynamic range.

Add a check for negative bounds, which can be caused by nasty negative mass inputs.

Add tests for both of these changes.

Make the template float-compatible by changing a couple of literals.

Add some formatting and comments improvments.

Affects issues #42 #43

@Rupt Rupt changed the title Add scale invariance and bounds checking #42 #43 Add scale invariance and bounds checking Mar 30, 2021
Copy link
Owner

@tpgillam tpgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tpgillam tpgillam merged commit 008fc6e into tpgillam:master Mar 30, 2021
This was referenced Mar 30, 2021
@tpgillam tpgillam mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants