Skip to content

Couple of small fixes/updates #14

Merged
merged 3 commits into from Mar 29, 2012

2 participants

@proby
Collaborator
proby commented Mar 29, 2012

I grouped three separate commits into one pull request. Feel free to take as many as you want or none of them. I was messing around with Legato and these commits are the results of little changes I had to make to get some of the existing features working.

@tpitale
Owner

What's the motivation behind this name change?

@tpitale
Owner
tpitale commented Mar 29, 2012

If you change those few little things, I'll merge this in and give you commit access. Thanks @proby!

@proby
Collaborator
proby commented Mar 29, 2012

GA expects 'sort' not 'order' as the key for the sorting value: http://code.google.com/apis/analytics/docs/gdata/v3/reference.html#sort. I thought it was easiest to change all instances.

@tpitale
Owner
tpitale commented Mar 29, 2012

Re: order => sort; cool. Let me know when you want me to merge it.

@tpitale tpitale merged commit 15276bc into tpitale:master Mar 29, 2012
@proby
Collaborator
proby commented Mar 29, 2012

Pushed the renaming to #number_for. I think it's ready for a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.