Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Null seed fails as a parent for any session based operation #1993

Closed
jejb opened this issue Feb 25, 2021 · 0 comments
Closed

The Null seed fails as a parent for any session based operation #1993

jejb opened this issue Feb 25, 2021 · 0 comments

Comments

@jejb
Copy link

jejb commented Feb 25, 2021

Trying to do any session based operation on something with the NULL seed as a parent results in authentication errors. This is a trace from trying to do TPM2_CreatePrimary with the NULL seed as a primaryHandle:

WARNING:esys:src/tss2-esys/api/Esys_CreatePrimary.c:393:Esys_CreatePrimary_Finish() Received TPM Error
ERROR:esys:src/tss2-esys/api/Esys_CreatePrimary.c:135:Esys_CreatePrimary() Esys Finish ErrorCode (0x000009a2)
TSS_CreatePrimary failed with 2466
tpm:session(1):authorization failure without DA implications

The session that's failing was created as a bound session on the NULL permanent handle, so it's not like this has security implications, but it's something that should work.

If you do the same operation with TPM_RS_PW instead of a real authentication session, everything works, so I think something is wrong in the HMAC routines when the NULL seed is specified either for binding or as a parent.

JuergenReppSIT added a commit to JuergenReppSIT/tpm2-tss that referenced this issue Feb 26, 2021
If ESYS_TR_RH_NULL was used as bind parameter for Esys_StartAuthSession the wrong HMAC
was computed, because the session was not treated as unbound session.
It will be checked whether no tpm key is passed and ESYS_TR_RH_NULL is used as bind
parameter to skip KDF computation of the session key.

Signed-off-by: Juergen Repp <juergen.repp@sit.fraunhofer.de>
JuergenReppSIT added a commit to JuergenReppSIT/tpm2-tss that referenced this issue Mar 1, 2021
If ESYS_TR_RH_NULL was used as bind parameter for Esys_StartAuthSession the wrong HMAC
was computed, because the session was not treated as unbound session.
It will be checked whether no tpm key is passed and ESYS_TR_RH_NULL is used as bind
parameter to skip KDF computation of the session key.

Signed-off-by: Juergen Repp <juergen.repp@sit.fraunhofer.de>
JuergenReppSIT added a commit to JuergenReppSIT/tpm2-tss that referenced this issue Mar 1, 2021
If ESYS_TR_RH_NULL was used as bind parameter for Esys_StartAuthSession the wrong HMAC
was computed, because the session was not treated as unbound session.
It will be checked whether no tpm key is passed and ESYS_TR_RH_NULL is used as bind
parameter to skip KDF computation of the session key.

Signed-off-by: Juergen Repp <juergen.repp@sit.fraunhofer.de>
AndreasFuchsTPM pushed a commit that referenced this issue Mar 1, 2021
If ESYS_TR_RH_NULL was used as bind parameter for Esys_StartAuthSession the wrong HMAC
was computed, because the session was not treated as unbound session.
It will be checked whether no tpm key is passed and ESYS_TR_RH_NULL is used as bind
parameter to skip KDF computation of the session key.

Signed-off-by: Juergen Repp <juergen.repp@sit.fraunhofer.de>
tstruk pushed a commit that referenced this issue Mar 5, 2021
If ESYS_TR_RH_NULL was used as bind parameter for Esys_StartAuthSession the wrong HMAC
was computed, because the session was not treated as unbound session.
It will be checked whether no tpm key is passed and ESYS_TR_RH_NULL is used as bind
parameter to skip KDF computation of the session key.

Signed-off-by: Juergen Repp <juergen.repp@sit.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant