New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined support for doobie #280 #456

Merged
merged 21 commits into from Feb 26, 2017

Conversation

Projects
None yet
4 participants
@btre
Contributor

btre commented Feb 3, 2017

Meta and Composite instances for refinement-types (including tests/ I think tests will also work as examples)

@tpolecat

This comment has been minimized.

Show comment
Hide comment
@tpolecat

tpolecat Feb 3, 2017

Owner

Thanks! CI issues in pre-2.12 Scala … looks minor.

Owner

tpolecat commented Feb 3, 2017

Thanks! CI issues in pre-2.12 Scala … looks minor.

@tpolecat

tpolecat requested changes Feb 4, 2017 edited

Thanks a bunch for this. I have a few requests, let me know if you disagree.

@tpolecat

This comment has been minimized.

Show comment
Hide comment
@tpolecat

tpolecat Feb 4, 2017

Owner

Also need to rebase, sorry. I slipped in a change underneath you.

Owner

tpolecat commented Feb 4, 2017

Also need to rebase, sorry. I slipped in a change underneath you.

@btre

This comment has been minimized.

Show comment
Hide comment
@btre

btre Feb 5, 2017

Contributor

thanks for your feedback. I'll work on the issues you've mentioned as soon as I can find time to do that.

Contributor

btre commented Feb 5, 2017

thanks for your feedback. I'll work on the issues you've mentioned as soon as I can find time to do that.

@beefyhalo

This comment has been minimized.

Show comment
Hide comment
@beefyhalo

beefyhalo Feb 12, 2017

beefyhalo commented Feb 12, 2017

@btre

This comment has been minimized.

Show comment
Hide comment
@btre

btre Feb 16, 2017

Contributor

thanks @beefyhalo, providing Atom-instances solved my problem

Contributor

btre commented Feb 16, 2017

thanks @beefyhalo, providing Atom-instances solved my problem

@tpolecat

This comment has been minimized.

Show comment
Hide comment
@tpolecat

tpolecat Feb 22, 2017

Owner

Is this ready to go? Looks good to me. Needs another rebase, sorry.

Owner

tpolecat commented Feb 22, 2017

Is this ready to go? Looks good to me. Needs another rebase, sorry.

@fthomas

This comment has been minimized.

Show comment
Hide comment
@fthomas

fthomas Feb 22, 2017

Contributor

Looks good to me too. 👍

Contributor

fthomas commented Feb 22, 2017

Looks good to me too. 👍

@tpolecat

This comment has been minimized.

Show comment
Hide comment
@tpolecat

tpolecat Feb 24, 2017

Owner

@btre can you rebase and also add your name/handle and a bullet point to the 0.4.2 in-progress section of the changelog?

Owner

tpolecat commented Feb 24, 2017

@btre can you rebase and also add your name/handle and a bullet point to the 0.4.2 in-progress section of the changelog?

@btre

This comment has been minimized.

Show comment
Hide comment
@btre

btre Feb 25, 2017

Contributor

@tpolecat I merged and updated the changelog

Contributor

btre commented Feb 25, 2017

@tpolecat I merged and updated the changelog

@tpolecat

This comment has been minimized.

Show comment
Hide comment
@tpolecat

tpolecat Feb 26, 2017

Owner

Thanks!

Owner

tpolecat commented Feb 26, 2017

Thanks!

@tpolecat tpolecat merged commit 3250986 into tpolecat:series/0.4.x Feb 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment