Skip to content

Conversation

@anark
Copy link
Contributor

@anark anark commented Jul 25, 2019

Hello,
When using dispatch with Fish shell set I get an empty output in all tmux windows while the command is running.

This fixes the output so the output shows while it is running.

@tpope
Copy link
Owner

tpope commented Jul 25, 2019

It was definitely added for a reason. Please blame the line and find the commit that added it so I can see if it's still relevant.

@anark
Copy link
Contributor Author

anark commented Jul 25, 2019

It was added in the commit to support fish shell(4566b88) and close the blank output issue(#217). However when I run Dispatch without this change the output in the tmux pane is blank. When I run it with this change the output displays correctly.

@tpope tpope merged commit 8e046e3 into tpope:master Jul 26, 2019
@tpope
Copy link
Owner

tpope commented Jul 26, 2019

Okay, since it was added with the rest of the Fish support I assume it was just based on my personal testing. I'm okay to remove it.

The real issue, though, appears to be a broken Fish behavior. The following command won't output anything until 10 seconds later after the entire begin block has finished running:

begin; echo test; sleep 10; end | cat

Appears to be a longstanding issue. fish-shell/fish-shell#1396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants