Completion context #214
Merged
Completion context #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got this working by yanking the whole toplevel form in one operation and then using strpart to select start and end parts. To find the cursor position I calculate number of characters in yanked text from start of the form to cursor pos. |
|
You're saving |
|
Thanks, that works. Other comments before I start cleaning this? |
|
I haven't fully digested the logic but looks good to me. I would favor pulling |
If complete operation is given context property containing the current toplevel form Compliment library can give better completion results in some contexts: - Local vars for let and defn - Resources in classpath for io/resource calls - Vars in specific ns for :require :refer - Better Java class name completion for :import The context string should contain symbol __prefix__ in place of the word being completed. To achieve this location of cursor inside the toplevel form is calculated so that the placeholder symbol can be placed in the proper place.
Deraen
force-pushed
the
completion-context
branch
from
221e3f2
to
c22e61c
Compare
|
Okay should be cleared now. |
|
Thanks for figuring this out; I'm excited to try it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
This is still work in progress but I opened this for comments and help.
My current strategy is to first yank from start of toplevel form to cursor and then from cursor to end of the form. Problem is that the latter yank is not working.