Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Toggling files in :Gstatus window by pressing - displays “Press ENTER or type command to continue” message #190

Closed
balinterdi opened this Issue Apr 19, 2012 · 7 comments

Comments

Projects
None yet
3 participants

I tried everything I found here and here to get rid of the message to no avail.

If I set cmdheight to >1 then it works for a few toggles and then displays the dreaded message again. (I could set cmdheight to e.g 3 to prevent this but the command line looks ugly that way)

I tried to find what message makes it display the message by checking the :file! value:

".git/index" [Not edited][RO] line 10 of 10 --100%-- col 1

That should not be a problem, I guess (textwidth is set to 0)

I also checked the v:scrollstart variable:

1 # On branch master
2 # Your branch is ahead of 'origin/master' by 1 commit.
3 #
4 # Changes not staged for commit:
5 #   (use "git add <file>..." to update what will be committed)
6 #   (use "git checkout -- <file>..." to discard changes in working directory)
7 #
8 # modified:   zshrc
9 #
10 no changes added to commit (use "git add" and/or "git commit -a")

This could be the culprit but I'm not sure.

I've created a pull request which does solve my issue although I know it's a hack so I don't expect it to be pulled in. I'm interested in the real solution though :) Thank you.

Owner

tpope commented Apr 21, 2012

Weird, I've never seen a "press ENTER" prompt from -. I normally run with cmdheight=2 but even when I reduce it to 1, I can't reproduce the message.

Have you tried stripping down to a minimal config? I suppose I could try the same.

I'm open to adding :silent (not :silent!) if we can't isolate the cause.

Very weird indeed. I've removed all plugins but fugitive and only kept the call pathogen#runtime_append_all_bundles() in my vimrc. That did not change anything, the "press ENTER" prompt still appeared.

Sorry, it took me some time to get back on this. I've replaced silent! with silent in my pull request as you suggested. Could you merge it back? Thank you.

Owner

tpope commented Dec 16, 2012

What OS are you running, and does this happen at the command line, the GUI, or both?

It happened in both the command line and the GUI (MacVim 7.3) application. The above fix works though so I no longer receive the message. I created a pull request you can merge back: #189 , unless you want to find out the exact cause.

Not sure if this is related but on MacVim 7.3 snapshot 66 I get the "Press ENTER or type command to continue" prompt when I run "dp" with a 3-way diff merge-conflicted file.

================ Vim command window: ==============

    Using /Users/me/.rvm/gems/ruby-1.9.3-p327
    Using /Users/me/.rvm/gems/ruby-1.9.3-p327
    Using /Users/me/.rvm/gems/ruby-1.9.3-p327
    Press ENTER or type command to continue

I also get the same thing when I run :Gwrite after resolving the conflicts

Owner

tpope commented Dec 28, 2012

@dougireton looks like you might have rvm.vim or something set to output the ruby version whenever you open a file?

@tpope tpope added a commit that referenced this issue Jan 1, 2013

@tpope tpope Fix supposed "Press ENTER" prompt
Closes #189, #190.
582eb0d

@tpope tpope closed this Jan 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment