Skip to content

Fixed an issue for overriden blame.date #242

Closed
wants to merge 1 commit into from

2 participants

@op
op commented Aug 22, 2012

If blame.date is configured to be anything except iso or short, the patterns will not match and the vertical split will be one column wide.

@op op Override date format in blame if unhandled
If blame.date is configured to be anything except iso or short, the
patterns will not match and the vertical split will be one column wide.
05edd77
@tpope tpope added a commit that referenced this pull request Aug 22, 2012
@tpope Fix :Gblame width with custom date format
Partially addresses #242.
f5b50f8
@tpope
Owner
tpope commented Aug 22, 2012

I think blocking some--but not all--custom date formats is confusing. Let's fix the patterns instead. I got the width one because it was obvious. What else is broken?

@op
op commented Aug 22, 2012

Sure, sounds like the best fix. I believe relative dates will be harder tho. I'm going to have a look at that fix you mentioned later.

@op
op commented Aug 22, 2012

That change fixes my initial problem. Cheers! Only short and iso works with resize to author/date.

The relative date is probably the hardest one to fix since I guess you can have the strings translated.

Why is there different patterns for date/time column and the default? That pattern works nice with relative dates too. If used, the only problem I still can see is with the author column size.

@op
op commented Aug 22, 2012

I looked at it and this was the closes I got to support all of them (assuming no-one has a number in its name, which isn't true).
'.{-}(([^0-9,]\ze)+'

With rfc using -3 and local -7, instead +1 would make it the correct size. I give up. I'm happy enough.

@op op closed this Aug 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.