New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ggrep: use current working directory #787

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dmerejkowsky
Copy link

dmerejkowsky commented Apr 30, 2016

Also, always call git with
--git-dir and
--work-tree

Fixes issue #753

Ggrep: use current working directory
Also, always call git with
 --git-dir and
 --work-tree

Fixes issue #753
@tpope

This comment has been minimized.

Copy link
Owner

tpope commented Apr 30, 2016

So what happens if the working directory isn't under the work tree at all?

@dmerejkowsky

This comment has been minimized.

Copy link

dmerejkowsky commented May 2, 2016

Hum. Did not think of this use case.

Let's assume you have a repo in /path/to/repo , and /path/to/repo/bar/baz that matches foo

If you run

:e /path/to/repo/some-file
:Ggrep foo

you get a quickfix list containing bar/baz : it's relative to the git repo and so you cannot open the file directly from the quickfix list.

Without my patch, you do get /path/to/repo/bar/baz in the quickfix list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment