Highlight SASS comments a little better #41

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@puyo
Contributor
puyo commented Nov 2, 2012

I like to put comments on the end of lines of SASS. // like this

But vim-haml doesn't highlight them.

I took a crack at fixing it. I don't know Vim syntax rules very well, but I think I nailed it.

-Greg

@aripatrick

Looks like you accidentally removed the 's' from 'scssComment'

Owner
puyo replied Nov 4, 2012

That was deliberate.

This file imports css.vim and uses its definitions, but it doesn't import scss.vim. I figured the references to scss in this file were mistakes. Changing this to cssComment caused /* */ style comments on the ends of lines to work.

I could be mistaken about css.vim and scss.vim though, as my understanding of how these files work is not complete.

The original was correct. The SCSS highlighting wraps the Sass highlighting and depends on this. (This is exactly backwards, but I implemented Sass highlighting first and haven't had a chance to invert the dependency.)

Since I've waited to the last minute to merge this, I've gone ahead and squashed in a fix.

@tpope tpope closed this May 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment