Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Starting basic Cell support #61

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

Hey Tim,

I'm kinda liking the idea of "Apotomo Widgets":https://github.com/apotonick/apotomo/ , so I started to add some basic functionality to rails.vim. Frankly, this is my first real vimscript hacking, so I'm going in small chunks.

Anyway, I guess the real question is: does this belong in rails.vim? or should there be a new vim script such as apotomo.vim?

Then again, feel free to reject outright. =)

:brad

Owner

tpope commented Jan 2, 2011

Hi Brad,

I am indeed pretty reluctant to add support for third party libraries, partially because there's so damn many and they change so fast, and partially because rails.vim is already a 5000 line monster without them. I only heard about Apotomo this week. I'm certainly not ready to commit to it long term, although everything is on a case-by-case basis.

For example, your change to s:readable_controller_name() is only two lines, has a relatively low maintenance cost, is hella useful (if indeed a cell name corresponds to a controller name; that's not my initial impression but I haven't looked at Apotomo that closely), and most importantly, is more or less impossible to pull off from outside of rails.vim. Put that in a separate patch and I'll accept it.

On the other hand, adding a navigation command takes 3 hunks to implement, interfaces with some old brittle navigation code I don't really want anything else to depend on, and is easily implemented from outside with a simple :Rnavcommand cell app/cells. The path changes are pretty easy to pull off externally as well. Syntax highlighting isn't quite that straightforward but is definitely doable. Every plugin or gem out the has some macro it wants highlighted; the only one I've caved in on is RSpec.

I also see you touched the old project.vim code. That's been deprecated for over a year; now seems like a good time to ax it for good.

Thanks for the guidance; I'm just another one of those recent vim converts flailing about to make my life slightly easier. Time to take a serious stab at fully ingesting vim-rails/doc/rails.txt.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment