Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cli to 2.2.4 #5

Closed
wants to merge 1 commit into from
Closed

Bump cli to 2.2.4 #5

wants to merge 1 commit into from

Conversation

hadim
Copy link

@hadim hadim commented Oct 12, 2020

No description provided.

@hadim hadim requested a review from tprasadtp as a code owner October 12, 2020 16:43
@tprasadtp tprasadtp added Docker maintenance Maintenance tasks/chore labels Oct 13, 2020
@tprasadtp
Copy link
Owner

Hello @hadim,
Thank you for the PR. Under the hood protonvpv cli has changed the way it handles openvpn config files. Now they are using jinja2 templates to generate them. I will take a look at this PR over the weekend and test it a bit so that it does not break anything.

@hadim
Copy link
Author

hadim commented Dec 1, 2020

Friendly bump here !

@tprasadtp
Copy link
Owner

tprasadtp commented Jan 7, 2021

This PR doesn't (yet) take into consideration the internal changes of protonvpn-cli. As I said earlier, the new version of cli uses jinja for templating. configuration files and scripts should be updated to accommodate such a change. Bumping just the cli to latest version from upstream might lead to breaking changes.

What needs to be done:

  • - Remove included template and let protonvpn generate templates on every fresh start/restart of vpn
  • Update to accommodate credentials config changes

@tprasadtp
Copy link
Owner

closing in favor of #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance tasks/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants