Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set_description with tqdm.notebook(disable=True) #669

Merged
merged 4 commits into from Feb 16, 2020

Conversation

mihaild
Copy link
Contributor

@mihaild mihaild commented Feb 1, 2019

As self.sp() is called in other places as well (for example if iterable raises exception), I think it's safer to allow calling it even for disabled instances.

@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #669 into master will increase coverage by 13.62%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #669       +/-   ##
===========================================
+ Coverage   85.56%   99.19%   +13.62%     
===========================================
  Files          15       10        -5     
  Lines         977      748      -229     
  Branches      169      132       -37     
===========================================
- Hits          836      742       -94     
+ Misses        136        2      -134     
+ Partials        5        4        -1

@codecov-io
Copy link

Codecov Report

Merging #669 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   99.19%   99.19%   +<.01%     
==========================================
  Files          10       10              
  Lines         747      748       +1     
  Branches      132      132              
==========================================
+ Hits          741      742       +1     
  Misses          2        2              
  Partials        4        4

@casperdcl casperdcl self-assigned this Feb 1, 2019
@casperdcl casperdcl added p3-enhancement 🔥 Much new such feature submodule-notebook 📓 Much web such IDE to-review 🔍 Awaiting final confirmation labels Feb 1, 2019
@casperdcl casperdcl assigned chengs and unassigned casperdcl Feb 1, 2019
@casperdcl casperdcl assigned casperdcl and unassigned chengs Jan 18, 2020
@casperdcl casperdcl added this to the v5.0.0 milestone Jan 18, 2020
@casperdcl casperdcl added to-merge ↰ Imminent and removed to-review 🔍 Awaiting final confirmation labels Jan 18, 2020
@casperdcl casperdcl added the p0-bug-critical ☢ Exception rasing label Feb 16, 2020
@casperdcl
Copy link
Sponsor Member

casperdcl commented Feb 16, 2020

@casperdcl casperdcl added this to Next Release in Casper Feb 16, 2020
@mihaild mihaild requested review from casperdcl and a team as code owners February 16, 2020 14:22
@casperdcl casperdcl changed the base branch from master to devel February 16, 2020 14:24
@casperdcl casperdcl changed the title Fix #650 Fix set_description with tqdm.notebook(disable=True) Feb 16, 2020
@casperdcl casperdcl linked an issue Feb 16, 2020 that may be closed by this pull request
3 tasks
@casperdcl casperdcl merged commit e5e7f8f into tqdm:devel Feb 16, 2020
Casper automation moved this from Next Release to Done Feb 16, 2020
@casperdcl casperdcl mentioned this pull request Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0-bug-critical ☢ Exception rasing p3-enhancement 🔥 Much new such feature submodule-notebook 📓 Much web such IDE to-merge ↰ Imminent
Projects
Casper
  
Done
Development

Successfully merging this pull request may close these issues.

'tqdm_notebook.set_description()' fails with disable=True
4 participants