Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Not found #56

Closed
dbapl opened this issue Jul 7, 2015 · 2 comments
Closed

URL Not found #56

dbapl opened this issue Jul 7, 2015 · 2 comments

Comments

@dbapl
Copy link

dbapl commented Jul 7, 2015

When master is installed on server witch multiple Trac environments, plugin tries to access URL:
https://trac.example.com/subscription/trac/project/browser
Trac project is on URL:
https://trac.example.com/trac/project/
so it will never hit Trac environment.

The same will happen with one Trac environment not installed on domain root. For example when Subversion and Trac work on the same server/domain this plugin will be unusable.

@dbapl dbapl changed the title URL Nor found URL Not found Jul 7, 2015
@nb
Copy link
Contributor

nb commented Jul 7, 2015

Hey, @esyscoder, in what cases do you see this URL? I can't reproduce it, so I will need more details and possibly steps to reproduce the problem. Thanks!

@dbapl
Copy link
Author

dbapl commented Jul 7, 2015

For example when I go to changset page, I see JS alert "Not found", because JS is trying to go to URL I mentioned.
To reporoduce install Trac in subdirectory not on the root of the server.

The code that makes this bug is in code-comments.js:

  window.Subscription = Backbone.Model.extend({
    url: '/subscription' + location.pathname,
  });

It gives always root of the server but Trac can be in subdirectory.

@schwuk schwuk self-assigned this Jul 10, 2015
@schwuk schwuk closed this as completed in cd48bc6 Jul 14, 2015
schwuk added a commit that referenced this issue Jul 14, 2015
Fixes #56 by not hardcoding the `subscription` URL
@nb nb unassigned schwuk May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants