better exception handling

tracim · Sep 27, 2018 · dfbbaa3 · dfbbaa3
1 parent 02f6de4
commit dfbbaa3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/backend/tracim_backend/lib/mail_notifier/notifier.py b/backend/tracim_backend/lib/mail_notifier/notifier.py
@@ -1,6 +1,5 @@
 # -*- coding: utf-8 -*-
 import datetime
-import traceback
 import typing
 
 from email.mime.multipart import MIMEMultipart
@@ -130,7 +129,7 @@ def notify_content_update(self, content: Content):
         except Exception as e:
             # TODO - G.M - 2018-08-27 - Do Better catching for exception here
             logger.error(self, 'Exception catched during email notification: {}'.format(e.__str__()))
-            logger.error(self, traceback.format_exc())
+            logger.exception(self, e)
 
 
 class EmailManager(object):

diff --git a/backend/tracim_backend/lib/utils/logger.py b/backend/tracim_backend/lib/utils/logger.py
@@ -43,5 +43,10 @@ def warning(self, instance_or_class, message):
             Logger.TPL.format(cls=self._txt(instance_or_class), msg=message)
         )
 
+    def exception(self, instance_or_class, message):
+        self._logger.exception(
+            Logger.TPL.format(cls=self._txt(instance_or_class), msg=message)
+        )
+
 
 logger = Logger('tracim')