Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node 14, support Node 16 and 18 #301

Merged
merged 1 commit into from
Oct 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
# Node 15 is currently broken, Node 12 is almost EOL, Node 16 isn't out
node-version: ["14"]
node-version: ["14", "16", "18"]

steps:
- uses: actions/checkout@v2
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
<img src='https://img.shields.io/npm/v/ember-async-data.svg' alt='npm'>
</a>
<a href='https://github.com/chriskrycho/ember-async-data/blob/main/.github/workflows/CI.yml#L29'>
<!--<img src='https://img.shields.io/badge/Node-14%20LTS%20%7C%2015-darkgreen' alt='supported Node versions'>-->
<img src='https://img.shields.io/badge/Node-14%20LTS-darkgreen' alt='supported Node versions'>
<img src='https://img.shields.io/badge/Node-14%20LTS%20%7C%2016%20LTS%20%7C%2018-darkgreen' alt='supported Node versions'>
</a>
<a href='https://github.com/chriskrycho/ember-async-data/blob/main/.github/workflows/CI.yml#L61'>
<img src='https://img.shields.io/badge/TypeScript-4.5%20%7C%204.6%20%7C%204.7%20%7C%20next-3178c6' alt='supported TypeScript versions'>
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"webpack": "^5.64.1"
},
"engines": {
"node": "12.* || >= 14"
"node": "14.* || 16.* || >= 18"
},
"ember": {
"edition": "octane"
Expand All @@ -103,7 +103,7 @@
}
},
"volta": {
"node": "14.19.0",
"yarn": "1.22.10"
"node": "14.20.1",
"yarn": "1.22.19"
}
}