Work around bad ember-cli-babel and preset-env interaction #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets us on the relevant latest versions of *all* of our dependencies, transitive and otherwise, including the latest versions of `@babel/preset-env` and `ember-cli`, which together trigger the build error seen in #204 and emberjs/ember-cli-babel#419. **This commit fails intentionally.** The follow-on commit will fix it, and the CI history will thereby act equivalent to a fixed failing test.
chriskrycho
changed the title
|
Will actually be resolved via emberjs/ember-cli-babel#420 (and cannot be resolved directly here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us on the relevant latest versions of all of our dependencies, transitive and otherwise, including the latest versions of
@babel/preset-envandember-cli, which together trigger the build error seen in v2 error: class private methods are not enabled #204 and Class private methods are not enabled. emberjs/ember-cli-babel#419.The first commit fails intentionally. The follow-on commit will fix it, and the CI history will thereby act equivalent to a fixed failing test.