Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make order number visible during ordering #168

Merged
merged 3 commits into from Apr 7, 2019

Conversation

Projects
None yet
2 participants
@wizzu
Copy link
Contributor

wizzu commented Apr 6, 2019

Make order number visible during ordering by adding order number to tickets_order_fragment.pug
Since the order number is probably the least important part normally, it's added to the bottom of the page. No highlight formatting is used for the same reason.

Exposing the order number here allows referencing the order number when registering payments via other means (e.g. credit/debit card with PoS reader over the counter) without requiring ticket sales admin rights.

@wizzu wizzu force-pushed the wizzu:tickets_visible_order_id branch from b7dd8d6 to 4e85100 Apr 6, 2019

@wizzu

This comment has been minimized.

Copy link
Contributor Author

wizzu commented Apr 6, 2019

This is how it looks (Chrome/Linux, apparently using locale en):
Kompassi-tickets-order-number-visible

@wizzu

This comment has been minimized.

Copy link
Contributor Author

wizzu commented Apr 6, 2019

And how it looks with Finnish locale:
Kompassi-tickets-visible-order-id-FI

@wizzu wizzu force-pushed the wizzu:tickets_visible_order_id branch from 4e85100 to 23f27dc Apr 7, 2019

@wizzu

This comment has been minimized.

Copy link
Contributor Author

wizzu commented Apr 7, 2019

Switched to use floating right muted text for the order number in the confirm page:
Kompassi-tickets-order-number-visible-float

Now the order number is also passed to checkout, here's how that looks:
Kompassi-tickets-order-number-visible-checkout

@japsu

japsu approved these changes Apr 7, 2019

@japsu japsu merged commit ac632e2 into tracon:development Apr 7, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@wizzu wizzu deleted the wizzu:tickets_visible_order_id branch Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.