From 9447ec1544c833ba21b3fa14327fc83c21617996 Mon Sep 17 00:00:00 2001
From: Mark Vayngrib <mark@tradle.io>
Date: Fri, 24 Nov 2017 15:40:40 -0500
Subject: [PATCH] fix: forbid scans of bucket tables

---
 lib/db.js                          | 1 +
 lib/samplebot/strategy/products.js | 2 +-
 src/db.ts                          | 1 +
 src/samplebot/strategy/products.ts | 2 +-
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/db.js b/lib/db.js
index 05a17558c..3bfc08e00 100644
--- a/lib/db.js
+++ b/lib/db.js
@@ -15,6 +15,7 @@ module.exports = function createDB(opts) {
         objects,
         docClient: aws.docClient,
         maxItemSize: constants.MAX_DB_ITEM_SIZE,
+        forbidScan: true,
         defaultReadOptions: {
             consistentRead: true
         }
diff --git a/lib/samplebot/strategy/products.js b/lib/samplebot/strategy/products.js
index 643d0e466..37c6b00ec 100644
--- a/lib/samplebot/strategy/products.js
+++ b/lib/samplebot/strategy/products.js
@@ -34,7 +34,7 @@ const DONT_FORWARD_FROM_EMPLOYEE = [
 ];
 const USE_ONFIDO = false;
 function createProductsBot(opts = {}) {
-    const { conf, onfido, bot, models = baseModels, products = DEFAULT_PRODUCTS, namespace = 'test.bot', queueSends, approveAllEmployees, autoVerify, autoApprove, graphqlRequiresAuth } = opts;
+    const { conf, onfido = {}, bot, models = baseModels, products = DEFAULT_PRODUCTS, namespace = 'test.bot', queueSends, approveAllEmployees, autoVerify, autoApprove, graphqlRequiresAuth } = opts;
     if (!bot) {
         throw new Error('expected "bot"');
     }
diff --git a/src/db.ts b/src/db.ts
index 82fbb8f3f..24caa0091 100644
--- a/src/db.ts
+++ b/src/db.ts
@@ -27,6 +27,7 @@ export = function createDB (opts: {
     objects,
     docClient: aws.docClient,
     maxItemSize: constants.MAX_DB_ITEM_SIZE,
+    forbidScan: true,
     defaultReadOptions: {
       consistentRead: true
     }
diff --git a/src/samplebot/strategy/products.ts b/src/samplebot/strategy/products.ts
index 683331aa5..33b2d9ee0 100644
--- a/src/samplebot/strategy/products.ts
+++ b/src/samplebot/strategy/products.ts
@@ -31,7 +31,7 @@ const USE_ONFIDO = false
 export default function createProductsBot (opts={}) {
   const {
     conf,
-    onfido,
+    onfido={},
     bot,
     models=baseModels,
     products=DEFAULT_PRODUCTS,