Skip to content

Add jaeger helm chart#79

Merged
dtomcej merged 10 commits intotraefik:masterfrom
mmatur:feature/add-tracing
Jun 24, 2019
Merged

Add jaeger helm chart#79
dtomcej merged 10 commits intotraefik:masterfrom
mmatur:feature/add-tracing

Conversation

@mmatur
Copy link
Copy Markdown
Member

@mmatur mmatur commented Jun 21, 2019

Description

This Pr adds jaeger tracing in the project

@dtomcej
Copy link
Copy Markdown
Contributor

dtomcej commented Jun 21, 2019

Do we intend to have zipkin running locally?

or can we remove the zipkin tracing stuff if we are going to use jaeger?

Also, is there a particular reason we have the ingress created and the api exposed?

Is it just to be able to view the routes that are being created?

@dtomcej
Copy link
Copy Markdown
Contributor

dtomcej commented Jun 21, 2019

We should also look at having these things disabled by default when we install the helm chart in the integration tests :P or else our tests are going to take much longer to run 😄

Copy link
Copy Markdown
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so close!

kind: CustomResourceDefinition
metadata:
name: tlsoptions.traefik.containo.us

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs the CRD Hook annotations :)

Comment thread internal/k8s/client.go Outdated
rewrite continue {
name regex ([a-z]*)\.([a-z]*)\.traefik\.mesh traefik-{1}-{2}.traefik-mesh.svc.cluster.local
answer name traefik-([a-z]*)-([a-z]*)\.traefik-mesh\.svc\.cluster\.local {1}.{2}.traefik.mesh
name regex ([a-z0-9-_]*)\.([a-z0-9-_]*)\.traefik\.mesh traefik-{1}-{2}.traefik-mesh.svc.cluster.local
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need to add capitals to this? I only ask due to being unsure if case-sensitive DNS is an issue...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think that we should add capitals.

@mmatur
Copy link
Copy Markdown
Member Author

mmatur commented Jun 24, 2019

Blocked by traefik/traefik#5007

@dtomcej
Copy link
Copy Markdown
Contributor

dtomcej commented Jun 24, 2019

traefik/traefik#5007 has been merged. Ready to proceed once the experimental image is built.

@SantoDE
Copy link
Copy Markdown

SantoDE commented Jun 24, 2019

Will test tonight or tomorow and report back if wanted :)

Copy link
Copy Markdown
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@dtomcej dtomcej merged commit 215e8bf into traefik:master Jun 24, 2019
@mmatur mmatur deleted the feature/add-tracing branch June 24, 2019 15:59
@mmatur mmatur mentioned this pull request Jun 24, 2019
@mmatur mmatur added this to the v0.1.0 milestone Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants