Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production ready #104

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Production ready #104

merged 2 commits into from
Mar 11, 2020

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Mar 11, 2020

Description

The helm chart is now production ready

Fixes #92

@mmatur mmatur requested a review from ldez March 11, 2020 14:16
SantoDE
SantoDE approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

ldez
ldez approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 1a6c178 into traefik:master Mar 11, 2020
@mmatur mmatur deleted the production-ready branch March 12, 2020 10:51
@dtomcej dtomcej mentioned this pull request Mar 18, 2020
Closed
@mickkael mickkael mentioned this pull request Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What keeps this repository from being "Production Ready"?
4 participants
@mmatur @SantoDE @ldez @traefiker