Add encodings option to the compression middleware#10943
Merged
traefiker merged 12 commits intotraefik:masterfrom Aug 7, 2024
Merged
Add encodings option to the compression middleware#10943traefiker merged 12 commits intotraefik:masterfrom
traefiker merged 12 commits intotraefik:masterfrom
Conversation
kevinpollet
requested changes
Jul 29, 2024
Member
kevinpollet
left a comment
There was a problem hiding this comment.
Hi @wollomatic,
Thanks for this contribution,
I added a couple of comments and we rebased this pull request on branch v3.1 as this is a new feature.
rtribotte
reviewed
Aug 5, 2024
Member
|
Hey @wollomatic, We are reviewing your pull request, and we would like to iterate on it. |
Contributor
Author
|
Hi @kevinpollet sure, thanks! |
…ik#10927, autogenerated content
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
4cbb49d to
9e5edff
Compare
Contributor
Author
|
Thank you! |
Contributor
|
🚫 checks status: PR status: failure |
8beee93 to
28d6fb8
Compare
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds an option to configure the allowed compression encodings to the compression middleware:
Implements #10927
Motivation
Some enterprise firewalls don't support zstd compression yet, so websites using Traefik 3.1 with the compress middleware can cause problems in some corporate networks.
More
Additional Notes
Despite that enhancements should be merged into the master branch, I chose the v3.1 branch because the feature is only relevant for Traefik v3.1+