Skip to content

Add encodings option to the compression middleware#10943

Merged
traefiker merged 12 commits intotraefik:masterfrom
wollomatic:compression-encodings-allowlist
Aug 7, 2024
Merged

Add encodings option to the compression middleware#10943
traefiker merged 12 commits intotraefik:masterfrom
wollomatic:compression-encodings-allowlist

Conversation

@wollomatic
Copy link
Contributor

@wollomatic wollomatic commented Jul 28, 2024

What does this PR do?

This adds an option to configure the allowed compression encodings to the compression middleware:

http:
  middlewares:
    test-compress:
      compress:
        encodings:
          - gzip
          - zstd
          - br

Implements #10927

Motivation

Some enterprise firewalls don't support zstd compression yet, so websites using Traefik 3.1 with the compress middleware can cause problems in some corporate networks.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Despite that enhancements should be merged into the master branch, I chose the v3.1 branch because the feature is only relevant for Traefik v3.1+

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wollomatic,

Thanks for this contribution,

I added a couple of comments and we rebased this pull request on branch v3.1 as this is a new feature.

@wollomatic wollomatic requested a review from kevinpollet July 30, 2024 11:09
@kevinpollet kevinpollet changed the title Add compression middleware encodings allowlist, implements #10927 Add compression middleware encodings allowlist Aug 1, 2024
@kevinpollet
Copy link
Member

Hey @wollomatic,

We are reviewing your pull request, and we would like to iterate on it.
Is it ok for you if we push a review commit on it?

@wollomatic
Copy link
Contributor Author

Hi @kevinpollet sure, thanks!

wollomatic and others added 2 commits August 7, 2024 10:11
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
@kevinpollet kevinpollet force-pushed the compression-encodings-allowlist branch from 4cbb49d to 9e5edff Compare August 7, 2024 13:06
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@wollomatic
Copy link
Contributor Author

Thank you!

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevinpollet kevinpollet changed the title Add compression middleware encodings allowlist Add encodings option to the compression middleware Aug 7, 2024
@traefiker
Copy link
Contributor

🚫 checks status: PR status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants