Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add udp timeout configuration #6982

Merged

Conversation

Lindenk
Copy link
Contributor

@Lindenk Lindenk commented Jun 30, 2020

What does this PR do?

Fixes issue #6859

Motivation

The UDP endpoint feature is rather useless if traefik closes the session after 3 seconds. My particular use case is to route mumble voip packets through traefik and having the server break after 3 seconds of inactivity is not useful.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

If there is a recommended alternative for creating a dummy ticker, that might be a better solution for the implementation of timeout values of 0.

@SantoDE SantoDE added this to To review in v2 via automation Jul 1, 2020
@jbdoumenjou jbdoumenjou added the kind/enhancement a new or improved feature. label Jul 1, 2020
@rtribotte rtribotte requested review from kevinpollet and rtribotte and removed request for kevinpollet September 11, 2020 12:37
@jbdoumenjou jbdoumenjou force-pushed the feature/add_udp_timeout_configuration branch from 2312e49 to f4d0e29 Compare January 6, 2021 09:47
@kevinpollet kevinpollet added this to the next milestone Jan 6, 2021
@jbdoumenjou jbdoumenjou closed this Jan 6, 2021
v2 automation moved this from To review to Done Jan 6, 2021
@jbdoumenjou jbdoumenjou reopened this Jan 6, 2021
@kevinpollet kevinpollet changed the title Feature: Add udp timeout configuration Feature: add udp timeout configuration Jan 6, 2021
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jspdown jspdown force-pushed the feature/add_udp_timeout_configuration branch from 1c251d4 to 7beaf38 Compare January 7, 2021 14:35
Copy link
Contributor

@jspdown jspdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@traefiker traefiker merged commit fc7ec17 into traefik:master Jan 7, 2021
@ldez ldez changed the title Feature: add udp timeout configuration Add udp timeout configuration Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/udp kind/enhancement a new or improved feature.
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

10 participants