New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add udp timeout configuration #6982
Merged
traefiker
merged 8 commits into
traefik:master
from
Lindenk:feature/add_udp_timeout_configuration
Jan 7, 2021
Merged
Add udp timeout configuration #6982
traefiker
merged 8 commits into
traefik:master
from
Lindenk:feature/add_udp_timeout_configuration
Jan 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevtainer
reviewed
Aug 21, 2020
rtribotte
requested review from
kevinpollet and
rtribotte
and removed request for
kevinpollet
September 11, 2020 12:37
jbdoumenjou
force-pushed
the
feature/add_udp_timeout_configuration
branch
from
January 6, 2021 09:47
2312e49
to
f4d0e29
Compare
kevinpollet
changed the title
Feature: Add udp timeout configuration
Feature: add udp timeout configuration
Jan 6, 2021
juliens
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ldez
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jspdown
force-pushed
the
feature/add_udp_timeout_configuration
branch
from
January 7, 2021 14:35
1c251d4
to
7beaf38
Compare
jspdown
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ldez
changed the title
Feature: add udp timeout configuration
Add udp timeout configuration
Apr 17, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue #6859
Motivation
The UDP endpoint feature is rather useless if traefik closes the session after 3 seconds. My particular use case is to route mumble voip packets through traefik and having the server break after 3 seconds of inactivity is not useful.
More
Additional Notes
If there is a recommended alternative for creating a dummy ticker, that might be a better solution for the implementation of timeout values of 0.