Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky integration tests #7403

Merged
merged 2 commits into from Oct 9, 2020
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 9, 2020

What does this PR do?

Waits a few milliseconds after sending SIGKILL.

Motivation

Attempts to fix flaky integration tests

FAIL: tcp_test.go:178: TCPSuite.TestCatchAllNoTLSWithHTTPS

traefik.go:76: command traefik error: error while building entryPoint tcp: error preparing server: error opening listener: listen tcp :8093: bind: address already in use

---

FAIL: headers_test.go:117: HeadersSuite.TestSecureHeadersResponses

command traefik error: error while building entryPoint web: error preparing server: error opening listener: listen tcp :8000: bind: address already in use

---

FAIL: grpc_test.go:220: GRPCSuite.TestGRPCh2cTermination

command traefik error: error while building entryPoint traefik: error preparing server: error opening listener: listen tcp :8080: bind: address already in use

---

FAIL: https_test.go:445: HTTPSSuite.TestWithClientCertificateAuthentication

traefik.go:76: command traefik error: error while building entryPoint traefik: error preparing server: error opening listener: listen tcp :8080: bind: address already in use

---

FAIL: https_test.go:692: HTTPSSuite.TestWithRootCAsContentForHTTPSOnBackend

traefik.go:76: command traefik error: error while building entryPoint traefik: error preparing server: error opening listener: listen tcp :8080: bind: address already in use

---

FAIL: https_test.go:301: HTTPSSuite.TestWithDefaultCertificate

traefik.go:76: command traefik error: error while building entryPoint websecure: error preparing server: error opening listener: listen tcp :4443: bind: address already in use

---

FAIL: acme_test.go:197: AcmeSuite.TestMultipleResolver

traefik.go:76: command traefik error: error while building entryPoint web: error preparing server: error opening listener: listen tcp :5002: bind: address already in use

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 2.3 milestone Oct 9, 2020
@ldez ldez added this to To review in v2 via automation Oct 9, 2020
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 5c85376 into traefik:v2.3 Oct 9, 2020
v2 automation moved this from To review to Done Oct 9, 2020
@ldez ldez deleted the fix/integration-test-stop branch October 9, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants