Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timezone without daylight saving time for logger formatter tests #7436

Merged
merged 1 commit into from Oct 22, 2020

Conversation

rtribotte
Copy link
Member

What does this PR do?

This PR replace the timezone US/Alaska in favor of Etc/GMT+9 to set a TZ timezone environment variable in logger formatter tests.

Motivation

Fix the logger formatter unit tests for specific platforms.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: jbdoumenjou 925513+jbdoumenjou@users.noreply.github.com

@sylr

This comment has been minimized.

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit fc97ea7 into traefik:v2.3 Oct 22, 2020
v2 automation moved this from To review to Done Oct 22, 2020
@rtribotte rtribotte deleted the fix-localtime-test branch November 20, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants