Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the same approach as the rules system on the TLS configuration choice #8764

Merged
merged 2 commits into from Feb 10, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 9, 2022

What does this PR do?

Apply the same approach as the rules system on the TLS configuration choice.

Motivation

The current implementation may be used to skip the TLS configuration set on a router if the host header is an FQDN.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Julien Salleyron julien.salleyron@gmail.com

@ldez ldez added this to the 2.6 milestone Feb 9, 2022
@ldez ldez added this to To review in v2 via automation Feb 9, 2022
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinpollet kevinpollet changed the title Apply the same approach as the rules system on the TLS configuration choice. Apply the same approach as the rules system on the TLS configuration choice Feb 10, 2022
@traefiker traefiker merged commit 0c83ee7 into traefik:v2.6 Feb 10, 2022
9 checks passed
v2 automation moved this from To review to Done Feb 10, 2022
@ldez ldez deleted the fix/tls-option branch February 10, 2022 09:48
@ldez ldez mentioned this pull request Feb 14, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants