Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should default to file_name.html.erb or .haml #480

Open
JohnSmall opened this issue Jul 9, 2019 · 1 comment
Open

should default to file_name.html.erb or .haml #480

JohnSmall opened this issue Jul 9, 2019 · 1 comment

Comments

@JohnSmall
Copy link

I see that someone else has had problems with Cells 4.x not following the standard conventions for naming templates. #460 But the solution is opaque .

We have a large project with a lot of .html.erb templates and _.html.erb partials which worked with cells 3.x and don't work with cells 4.x . I don't want to go through renaming them because it's an unnecessary pain.

Is there some reason why this change was made, and not documented in the upgrade guide?

If I forked the project, made a PR to correct this issue would it be accepted or is there some deep reason why the standard naming convention isn't being followed?

@seuros
Copy link
Member

seuros commented Jul 9, 2019

I believe that a Rails convention, so the patch should be in https://github.com/trailblazer/cells-rails.

Ping me on the PR when you have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants