New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Apotomo #28 issue #59

Merged
merged 2 commits into from Jul 13, 2011

Conversation

Projects
None yet
2 participants
@paneq
Contributor

paneq commented Jul 12, 2011

Fix multiple global inclusion of helpers from different controllers (also fix keeping included helpers from previous requests in development mode: apotonick/apotomo#28)

I hope you like it because it took me few hours to find to investigate this bug.

Fix multiple global inclusion of helpers from different controllers (…
…also fix keeping included helpers from previous requests in development mode: apotonick/apotomo#28)
@paneq

This comment has been minimized.

Show comment
Hide comment
@paneq

paneq Jul 12, 2011

Contributor

We should probably write a test for it and maybe also fix the strategy for rails 3.1 ?

Contributor

paneq commented Jul 12, 2011

We should probably write a test for it and maybe also fix the strategy for rails 3.1 ?

@paneq

This comment has been minimized.

Show comment
Hide comment
@paneq

paneq Jul 13, 2011

Contributor

I added a test for that fix and also checked that without my patch the test was failing.

Contributor

paneq commented Jul 13, 2011

I added a test for that fix and also checked that without my patch the test was failing.

@paneq

This comment has been minimized.

Show comment
Hide comment
@paneq

paneq Jul 13, 2011

Contributor

The test is passing for rails 3.1 without changes in rails3_1_strategy.rb

Contributor

paneq commented Jul 13, 2011

The test is passing for rails 3.1 without changes in rails3_1_strategy.rb

@apotonick

This comment has been minimized.

Show comment
Hide comment
@apotonick

apotonick Jul 13, 2011

Collaborator

So the Rails30 strategy has to be fixed, but 31 can stay as-it? Maybe I should ask José what has changed here?

Collaborator

apotonick commented Jul 13, 2011

So the Rails30 strategy has to be fixed, but 31 can stay as-it? Maybe I should ask José what has changed here?

@paneq

This comment has been minimized.

Show comment
Hide comment
@paneq

paneq Jul 13, 2011

Contributor

Yes. There are quite different in this element. After my fix both pass the test.

Contributor

paneq commented Jul 13, 2011

Yes. There are quite different in this element. After my fix both pass the test.

apotonick added a commit that referenced this pull request Jul 13, 2011

Merge pull request #59 from paneq/master
Use a separate Cell::View instance for each cell so helpers work as intended (Fix for Apotomo #28 issue).

@apotonick apotonick merged commit dbcfb13 into trailblazer:master Jul 13, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment