Skip to content

fix regex too complicated error in developer edition#313

Merged
pozil merged 2 commits into
trailheadapps:mainfrom
exiahuang:bugfix/regex-too-complicated-error
May 25, 2022
Merged

fix regex too complicated error in developer edition#313
pozil merged 2 commits into
trailheadapps:mainfrom
exiahuang:bugfix/regex-too-complicated-error

Conversation

@exiahuang

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix Regex too complicated error in developer edition

What issues does this PR fix or reference?

#312

The PR fulfills these requirements:

[x] Tests for the proposed changes have been added/updated.
[x] Code linting and formatting was performed.

Functionality Before

Regex too complicated Error.

Functionality After

Fix the error in DE.

@exiahuang exiahuang requested a review from a team as a code owner May 25, 2022 12:56
@salesforce-cla

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @exiahuang to sign the Salesforce.com Contributor License Agreement.

@codefriar

Copy link
Copy Markdown
Contributor

@exiahuang - Thanks for this PR. Your solution is elegant and I like the guard/continue pattern.

It does not, however, follow our style conventions in this Repo. Can you please tweak to include {}'s around the continue statement. I know it's not technically required by Apex, but it is how the rest of the Repo is done.

@exiahuang

Copy link
Copy Markdown
Contributor Author

@codefriar Thank you for for comment. I have fix it. Please check it again.

@codefriar codefriar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pozil I approve this PR

@msrivastav13

Copy link
Copy Markdown
Contributor

Thank you @codefriar and @exiahuang

@pozil pozil merged commit b15e34f into trailheadapps:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants