Fetch remote dylint_driver in dylint_testing by default
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver builder uses a remote `dylint_driver` package if building in release mode or if `dylint_driver_remote` is enabled. https://github.com/smoelius/dylint/blob/844a3ab339d0dcf69102044368b1bbd907b45787/dylint/src/driver_builder.rs#L112-L113 So when `dylint_testing` is built in debug mode, it looks for a local `dylint_driver` package and cannot find one. A solution is to have `dylint_testing` enable the `dylint_driver_remote` feature by default. I think I would prefer the feature be `dylint_driver_local`, but this solves the immediate problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver builder uses a remote
dylint_driverpackage if building in release mode or ifdylint_driver_remoteis enabled.https://github.com/smoelius/dylint/blob/844a3ab339d0dcf69102044368b1bbd907b45787/dylint/src/driver_builder.rs#L112-L113
So when
dylint_testingis built in debug mode, it looks for a localdylint_driverpackage and cannot find one.A solution is to have
dylint_testingenable thedylint_driver_remotefeature by default.I think I would prefer the feature be
dylint_driver_local, but this solves the immediate problem.