Add experimental --bisect option
#170
Conversation
smoelius
force-pushed
the
bisect
branch
3 times, most recently
from
62ccace
to
edbd3de
Compare
| const SCRIPT: &str = r#"#! /bin/bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| CHANNEL="$(echo "$RUSTUP_TOOLCHAIN" | sed -n 's/^bisector-\(nightly-[0-9]\{4\}-[0-9]\{2\}-[0-9]\{2\}\)-.*$/\1/;T;p')" | ||
|
|
||
| unset RUSTUP_TOOLCHAIN | ||
|
|
||
| if [[ -z "$CHANNEL" ]]; then | ||
| if [[ ! -f first_commit_seen ]]; then | ||
| touch first_commit_seen | ||
| exit 1 | ||
| else | ||
| exit 0 | ||
| fi | ||
| fi | ||
|
|
||
| # smoelius: The rust-toolchain file should reflect the most recent successful build. So if the | ||
| # current build fails, restore the rust-toolchain file's previous contents. | ||
| TMP="$(mktemp -p . -t rust-toolchain.XXXXXXXXXX)" | ||
| cp rust-toolchain "$TMP" | ||
| trap ' | ||
| STATUS="$?" | ||
| if [[ "$STATUS" -eq 0 ]]; then | ||
| rm "$TMP" | ||
| else | ||
| mv "$TMP" rust-toolchain | ||
| fi | ||
| exit "$STATUS" | ||
| ' EXIT | ||
|
|
||
| sed -i "s/^channel = \"[^\"]*\"$/channel = \"$CHANNEL\"/" rust-toolchain | ||
|
|
||
| if [[ ! -f first_channel_seen ]]; then | ||
| cargo build --tests || (touch first_channel_seen && false) | ||
| elif [[ ! -f successful_build_seen ]]; then | ||
| # smoelius: Pretend the build succeeds (even if it doesn't) and proceed backwards until we find | ||
| # one that actually succeeds. | ||
| (cargo build --tests && touch successful_build_seen) || true | ||
| else | ||
| cargo build --tests | ||
| fi | ||
| "#; |
There was a problem hiding this comment.
An easy way to make this cross-platform like this is something like https://github.com/matklad/xshell/, which has mostly the same syntax as shell, but uses Command::new under the hood and doesn't depend on a specific shell.
There was a problem hiding this comment.
Oh, I just saw you're passing the path to the script as an argument to some tool - maybe you could do that with xshell by adding a second binary and passing its path? something like src/bin/bisect.rs and then cargo install would install it alongside cargo-dylint.
There was a problem hiding this comment.
I think I like this idea.
However, given that the script mostly works and I have other priorities (cough), I will likely merge this as-is and make implementing your suggestion a TODO item.
Thanks, BTW.
No description provided.