New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evm's make_symbolic_address #1318

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@disconnect3d
Copy link
Contributor

disconnect3d commented Jan 1, 2019

The code that created a constrain for created symbolic address was unreachable.

Related issue: #1317

We should probably create a testcase for this but let's check if the tests pass after this change.


This change is Reviewable

@disconnect3d disconnect3d requested a review from feliam Jan 1, 2019

disconnect3d added some commits Jan 1, 2019

Fix evm's make_symbolic_address
The code that created a constrain for created symbolic address was
unreachable.

@disconnect3d disconnect3d force-pushed the fix-make-symbolic-address branch from 2597e12 to 84b37fa Jan 2, 2019

@feliam

feliam approved these changes Jan 2, 2019

@disconnect3d disconnect3d merged commit 64c75fb into master Jan 3, 2019

5 checks passed

codeclimate All good!
Details
codeclimate/total-coverage 70% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@disconnect3d disconnect3d deleted the fix-make-symbolic-address branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment