New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing consts in CLI args #1337

Merged
merged 5 commits into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@disconnect3d
Copy link
Contributor

disconnect3d commented Jan 10, 2019

Brings back config variables into CLI arguments.

Also removed duplicated arguments.

This change is Reviewable

@@ -39,16 +43,19 @@ class ManticoreBase(Eventful):

_published_events = {'start_run', 'finish_run', 'generate_testcase'}

def __init__(self, initial_state, workspace_url=None, policy='random', **kwargs):
def __init__(self, initial_state, workspace_url=None, policy='random', timeout=None, **kwargs):

This comment has been minimized.

@feliam

feliam Jan 10, 2019

Contributor

Do we need the timeout here if it is already a global config value ?

This comment has been minimized.

@disconnect3d

disconnect3d Jan 10, 2019

Contributor

It's the question where should the user specify it if they want to do so. Do you think they should use config.core.timeout instead?

This comment has been minimized.

@disconnect3d

disconnect3d Jan 10, 2019

Contributor

Let's leave it as an argument here as someone might want to use it when playing with scripts.

This comment has been minimized.

@feliam

feliam Jan 10, 2019

Contributor

Ok. Note though that she may still need to do some config.py setting even from a script.

@disconnect3d disconnect3d merged commit a812635 into master Jan 10, 2019

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codeclimate 1 fixed issue
Details
license/cla Contributor License Agreement is signed.
Details

@disconnect3d disconnect3d deleted the fix-missing-consts branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment