Skip to content

/ mishegos

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mishegos: Emit output in a binary format #34

Merged
merged 31 commits into from Jan 28, 2020
Merged

mishegos: Emit output in a binary format #34

merged 31 commits into from Jan 28, 2020

Conversation

@pothastm
Copy link
Contributor

@pothastm pothastm commented Jan 23, 2020 •
edited

Closes #11.

  • This is to make mishegos more performant by changing the output format from JSON
  • In cohorts.c changed the dump_cohorts() to directly dump the cohorts structs directly
  • With kaitai_source_code.ksy file can generate a python file that gets length and version-prefix for the structs
  • the generated python file can be used with mish2json.py to convert cohorts to JSON file
@pothastm pothastm requested a review from woodruffw Jan 23, 2020
@claassistantio
Copy link

@claassistantio claassistantio commented Jan 23, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
docs/output_cohorts_format.md Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
docs/output_cohorts_format.md Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
docs/output_cohorts_format.md Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
docs/output_cohorts_format.md Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
docs/output_cohorts_format.md Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
docs/output_cohorts_format.md Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
docs/output_cohorts_format.md Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
docs/output_cohorts_format.md Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
docs/output_cohorts_format.md Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
src/convert_to_JSON/cohort.py Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
src/convert_to_JSON/setup.py Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
src/convert_to_JSON/kaitai_source_code.ksy Outdated Show resolved Hide resolved
@woodruffw
woodruffw reviewed Jan 23, 2020
View changes
src/mish2json/Makefile Outdated Show resolved Hide resolved
@woodruffw woodruffw changed the title Tp performanceoutput mishegos: Emit output in a binary format' Jan 27, 2020
@woodruffw woodruffw changed the title mishegos: Emit output in a binary format' mishegos: Emit output in a binary format Jan 27, 2020
pothastm and others added 13 commits Jan 3, 2020
@pothastm @woodruffw
non JSON add new doc
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
6c8b4af
@pothastm @woodruffw
json convert ksy
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
10a9435
@pothastm @woodruffw
ran black for format
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
133384d
@woodruffw
tmp: Remove temporaries
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
d4f7a73
@pothastm @woodruffw
Makefile with convert_to_JSON
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
9179c59
@pothastm @woodruffw
add git to DockerFile
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
bf9c1d6
@woodruffw
Dockerfile, ci: Add kaitai-struct-compiler
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
9625332
@woodruffw
Makefile: Fixup, rename
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
0715dd5
@woodruffw
src: convert_to_JSON -> mish2json
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
2181f62
@pothastm @woodruffw
resolved comments
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
e6399e5
@woodruffw
Dockerfile: Remove sudos
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
4b43570
@woodruffw
Dockerfile: Ensure that gnupg is installed
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
07d3e6c
@woodruffw
Dockerfile: Fix apt invocations once and for all
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
85fed52
pothastm and others added 9 commits Jan 27, 2020
@pothastm @woodruffw
docker,makefil,md fix
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
f7d507b
@pothastm @woodruffw
uncomment make
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
9f08264
@woodruffw
Remove IDE files
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
90c654a
@woodruffw
Makefile: Remove space
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
00316f9
@woodruffw
mishegos/cohorts: clang-format
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
351dafd
@woodruffw
mish2json: Rename script
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
392816a
@pothastm @woodruffw
fix analysis files
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
7f5da9d
@woodruffw
Dockerfile, ci: Use MIT keyserver
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
38cd052
@woodruffw
Remove IDE files
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
Loading status checks…
5100683
@woodruffw woodruffw force-pushed the tp-performanceoutput branch from 6e3112d to 5100683 Jan 28, 2020
woodruffw added 9 commits Jan 28, 2020
@woodruffw
Dockerfile, ci: Switch to the ubuntu keyserver
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
Loading status checks…
4296474
@woodruffw
mishmat: Update key
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
6726ccb
@woodruffw
README: Document mish2jsonl
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
535f5d3
@woodruffw
Makefile, mish2jsonl: Restructure
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
Loading status checks…
b24f8d7
@woodruffw
fadec/Makefile: Use .ONESHELL
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
464ae87
@woodruffw
README: Update mish2jsonl docs
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
57a3876
@woodruffw
mish2jsonl: Support V=1
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
Loading status checks…
a784019
@woodruffw
docs: Rewrite cohort format docs
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
deba345
@woodruffw
Makefile, src: Remove vendored directory
Verified
This commit was signed with a verified signature.
woodruffw William Woodruff
GPG key ID: 70F70A3979DDCED3 Learn about signing commits
Loading status checks…
659e890 
No longer needed.
@woodruffw woodruffw merged commit 69a44fc into master Jan 28, 2020
3 checks passed
3 checks passed
lint
Details
build
Details
license/cla Contributor License Agreement is signed.
Details
@woodruffw woodruffw deleted the tp-performanceoutput branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Change output format to something more performant
3 participants
@pothastm @claassistantio @woodruffw
You can’t perform that action at this time.