Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mishegos: Emit output in a binary format #34

Merged
merged 31 commits into from Jan 28, 2020
Merged

mishegos: Emit output in a binary format #34

merged 31 commits into from Jan 28, 2020

Conversation

@pothastm
Copy link
Contributor

@pothastm pothastm commented Jan 23, 2020

Closes #11.

  • This is to make mishegos more performant by changing the output format from JSON
  • In cohorts.c changed the dump_cohorts() to directly dump the cohorts structs directly
  • With kaitai_source_code.ksy file can generate a python file that gets length and version-prefix for the structs
  • the generated python file can be used with mish2json.py to convert cohorts to JSON file
@pothastm pothastm requested a review from woodruffw Jan 23, 2020
@claassistantio
Copy link

@claassistantio claassistantio commented Jan 23, 2020

CLA assistant check
All committers have signed the CLA.

src/convert_to_JSON/setup.py Outdated Show resolved Hide resolved
src/mish2json/Makefile Outdated Show resolved Hide resolved
@woodruffw woodruffw changed the title Tp performanceoutput mishegos: Emit output in a binary format' Jan 27, 2020
@woodruffw woodruffw changed the title mishegos: Emit output in a binary format' mishegos: Emit output in a binary format Jan 27, 2020
pothastm and others added 13 commits Jan 3, 2020
pothastm and others added 9 commits Jan 27, 2020
@woodruffw woodruffw force-pushed the tp-performanceoutput branch from 6e3112d to 5100683 Jan 28, 2020
woodruffw added 9 commits Jan 28, 2020
No longer needed.
@woodruffw woodruffw merged commit 69a44fc into master Jan 28, 2020
3 checks passed
3 checks passed
lint
Details
build
Details
license/cla Contributor License Agreement is signed.
Details
@woodruffw woodruffw deleted the tp-performanceoutput branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.