Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several bugfixes to work with the newest Kanboard #9

Merged
merged 10 commits into from
Mar 19, 2018
Merged

Several bugfixes to work with the newest Kanboard #9

merged 10 commits into from
Mar 19, 2018

Conversation

5p4k
Copy link
Contributor

@5p4k 5p4k commented Jan 11, 2018

We are using Kanboard together with Ipsilon as IdP and FreeIPA; we has some issues, this PR fixes several of them:

  • name/email mismatch by smacz42
  • placeholders not being rendered in the settings because of wrong number of arguments in the form creation.
  • missing "save settings" button (can't find it anywhere!): temporarily fixed by hardcoding it in HTML (is this a Kanboard general issue?)
  • using git submodules to load php-saml; the version that was previously imported generated invalid metadata (at least for Ipsilon), and in this way maintaining it is way easier.
  • removed all hardcoded paths for the certificate and private key, replaced with settings (there was already a setting for the IdP certificate which was unused, so let's not make assumptions on where to find those files)
  • using full name instead of first + last name (see aaec9e4)

This is working fine in our setup.

smacz42 and others added 10 commits March 27, 2017 02:50
@smacz42
Implemented fix of name -> email
bd80bfa
@5p4k
Merge pull request #1 from smacz42/fix_email_value
e2310a5 
Implemented fix of name -> email
@5p4k
Fixing missing placeholders.
18de2a5
@5p4k
Added manual "save settings" button (missing)
2075fbb
@5p4k
Changing settings for SAML certificates.
7945b71 
Settings for the IDP certificate were available but not used.
Using the same policy for the SP certificate as well: instead
of fetching content of hardcoded file paths, certificate and
private key are provided as settings.
Also using the naming convention certificate/private key instead
of public/private certificate.
@5p4k
Added myself as contributor
32f149a
@5p4k
Removing php-saml, to replace with submodule
ad32575
@5p4k
Added submodule at v2.12.0
a39a84a
@5p4k
Using full name instead of chaining first and last name.
aaec9e4 
The code previously assigned as user name "first + ' ' + last".
This makes an assumption on the full name format which is
generally false, as in many cultures there are middle names
and there could well be a middle name attribute in the identity
provider which were not handling.
@5p4k
Slightly more descriptive instructions.
d67e0cd
@5p4k 5p4k changed the title Several bugfix to work with the newest Kanboard Several bugfixes to work with the newest Kanboard Jan 11, 2018
@5p4k 5p4k mentioned this pull request Jan 11, 2018
Closed
@trajche trajche merged commit b08d757 into trajche:master Mar 19, 2018
@toddejohnson toddejohnson mentioned this pull request Jan 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@5p4k @trajche @smacz42