Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java3D dependency in Java 6 and 8 #13

Closed
axtimwalde opened this issue Feb 16, 2016 · 5 comments
Closed

Java3D dependency in Java 6 and 8 #13

axtimwalde opened this issue Feb 16, 2016 · 5 comments

Comments

@axtimwalde
Copy link
Contributor

Summarizing previous discussion on other channels:

@axtimwalde: Did you have a chance to put the vecmath stuff into a separate package that is independent of Java8?

@ctrueden: Well, org.scijava:vecmath:1.6.0-scijava-2 is compatible with Java 1.5+; we could upload it to the Fiji update site if you wish. We would need to release a version of TrakEM2 that depends on the new vecmath, but not the new j3dcore or j3dutils artifacts though... more trouble than it's worth if you ask me, but ultimately up to you.

[...]

@ctrueden: Yes, Java 6 is most useful for Apple users, because Oracle Java 7 + 8 still have critical bugs. Java 3D 1.5.2 does work with Apple Java 6, and Java 3D 1.6.0-scijava-2 does work with Oracle Java 8, except there are still some bugs...

@axtimwalde
Copy link
Contributor Author

Solution suggested by @ctrueden: Keep current (frozen) version of TrakEM2 on Java 6 update site, put new version on Java 8 update site. I think this will break soon because TrakEM2 has too many dependencies. If any of these dependencies receives a Java 6 compatible upgrade that is incompatible with TrakEM2, TrakEM2 Java 6 will break. That means I will have to bugfix on two fronts which I would prefer to avoid. If it's easy enough to have org.scijava:vecmath:1.6.0-scijava-2 as a separate component on Fiji (both Java 6 and 8, because it does not require Java 8), I would strongly prefer this solution. The changes in df3be01 should cover this (except for dependencies in pom.xml which is easy).

@ctrueden
Copy link
Member

f any of these dependencies receives a Java 6 compatible upgrade that is incompatible with TrakEM2, TrakEM2 Java 6 will break.

If we create a java6 branch of sc.fiji:fiji, which we keep aligned with what's on the main Fiji & ImageJ update sites, then we can use the melting pot script to test for these breakages. (Though I suppose TrakEM2 is unfortunately light on unit tests...)

That means I will have to bugfix on two fronts which I would prefer to avoid.

100% agreed!

If it's easy enough to have org.scijava:vecmath:1.6.0-scijava-2 as a separate component on Fiji (both Java 6 and 8, because it does not require Java 8), I would strongly prefer this solution.

Sure, go for it then.

@ctrueden
Copy link
Member

@axtimwalde For what it's worth, due to your concerns above, @hinerm and I agreed to completely freeze the ImageJ and Fiji update sites until the Java 8 migration is totally complete. So we have been pushing all updates to the Java-8 update site only, now. Hopefully this avoids the skew you fear.

@axtimwalde
Copy link
Contributor Author

@ctrueden thanks for letting me know.

@ctrueden
Copy link
Member

I released pom-trakem2 version 2.0.0 with all TrakEM2 components including TrakEM2_ version 1.0h, and uploaded it all to the Java-8 update site. I did very little testing, although I did verify that zooming now works as expected. Further testing from the community would be very welcome.

bimoelle pushed a commit to prbio-hub/rhizoTrak that referenced this issue Feb 12, 2019
- added default segment status and removed integers (resolves trakem2#13)
- added config.xsd that defines project level settings (resolves trakem2#17)
- added settings.xsd that defines global settings in home folder
(resolves trakem2#18)
- added jaxb2-maven-plugin to the pom file
- cleaned and reorganized VisbilityPanel.java
- updated and reorganized RhizoAddons.java to handle the new xml files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants