New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more document types to the document uploader for HHG #1292

Merged
merged 2 commits into from Nov 2, 2018

Conversation

2 participants
@chrisgilmerproj
Contributor

chrisgilmerproj commented Nov 1, 2018

Description

We need more document types for HHG. The canonical list is here:

https://docs.google.com/document/d/1v4uDEYj6bsBN9UGcgGGk_HwNKGej8Kq3nA67sKPP2dk/edit?pli=1

This ticket doesn't add metadata for any new doc type, it just allows people to add new ones with specific types. I left out Pro-gear since it's not clear if that will be a needed doc type.

Reviewer Notes

Try uploading different types of documents. Would be good to exercise but I'm pretty sure they all work.

It's also unclear if a 619-1 is just for origin, delivery, or both. So I'm still working on that answer.

Setup

Open a shipment and try to upload a new document. Pick one of the new types from this PR.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

Screenshots

screen shot 2018-11-01 at 4 29 51 pm

@chrisgilmerproj chrisgilmerproj self-assigned this Nov 1, 2018

@chrisgilmerproj chrisgilmerproj requested review from kahlouie, sarboc and amitch23 Nov 1, 2018

WEIGHT_TICKET_REWEIGH: Weight ticket reweigh
ORIGIN_PACKET: Origin packet
ORIGIN_619: Origin 619
ORIGIN_619_1: Origin 619-1

This comment has been minimized.

@chrisgilmerproj

chrisgilmerproj Nov 1, 2018

Contributor

This may be a destination doc related to SIT. I'm confirming with the govies and will fix before I merge it.

This comment has been minimized.

@chrisgilmerproj

chrisgilmerproj Nov 2, 2018

Contributor

I got my answer - it's a destination doc. Updated the code!

@kahlouie

:shipit: once you get your answer :)

@chrisgilmerproj chrisgilmerproj merged commit 74b2704 into master Nov 2, 2018

9 checks passed

ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_161571942_add_more_document_types branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment