New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editable panel styling so that headers are darker and borders are dashed while editing #1308

Merged
merged 1 commit into from Nov 6, 2018

Conversation

3 participants
@chrisgilmerproj
Contributor

chrisgilmerproj commented Nov 6, 2018

Description

Just like the title. The wireframes showed this style, the style sheets appeared to have the correct styles, the class names were correct ... but it wasn't styled. Turns out we lost some spaces somewhere.

Setup

Add scenario 7 data. Go to any record in the TSP or Office app and edit any panel. You'll see the header get darker and the border become dashed.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

Screenshots

Before:

screen shot 2018-11-06 at 10 21 20 am

After:

screen shot 2018-11-06 at 10 21 34 am

@chrisgilmerproj chrisgilmerproj self-assigned this Nov 6, 2018

@kilbergr

👍

@kimallen

This comment has been minimized.

Contributor

kimallen commented Nov 6, 2018

Are the panels only supposed to be darker when in edit mode, not regular? If so, looks good!

@chrisgilmerproj chrisgilmerproj merged commit 369990f into master Nov 6, 2018

9 checks passed

ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_161739767_editable_panel_darker_header_dashed_border branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment