New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move locations panel to the correct spot in the page #1311

Merged
merged 1 commit into from Nov 7, 2018

Conversation

2 participants
@chrisgilmerproj
Contributor

chrisgilmerproj commented Nov 7, 2018

Description

The locations panel is styled correctly but it was in the wrong spot on the page. This puts it between the Weights and Preapprovals panels as in the wireframes.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@chrisgilmerproj chrisgilmerproj self-assigned this Nov 7, 2018

@kahlouie

🚢

@chrisgilmerproj chrisgilmerproj merged commit 5a06805 into master Nov 7, 2018

9 checks passed

ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_161597096_style_locations_panel branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment