New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Check JSON Output #1414

Merged
merged 1 commit into from Dec 4, 2018

Conversation

3 participants
@pjdufour-truss
Contributor

pjdufour-truss commented Dec 4, 2018

Description

Health check now returns a JSON blob that includes the git commit hash, git branch, and whether the database is up. This can be used to improve verifying automated deploys.

Setup

curl -XGET -k https://localhost:8443/health
{"database":true,"gitBranch":"health_check_json","gitCommit":"bbaa185a76cbb3d6c20d8a2278769820e7e02b14"}
@chrisgilmerproj

This comment has been minimized.

Contributor

chrisgilmerproj commented Dec 4, 2018

@akostibas - I'm hoping this is sufficient for a health check (ie DB is up and we deployed the hash we expected). Is there another server-side check we would need to do? Or do we need to expose this on the client and also check something there?

@akostibas

This is great! Should give us everything we need.

@chrisgilmerproj

🚢

@pjdufour-truss pjdufour-truss merged commit 8556a49 into master Dec 4, 2018

9 checks passed

ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@pjdufour-truss pjdufour-truss deleted the health_check_json branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment