New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for applying a secure migration only to staging #1422

Merged
merged 1 commit into from Dec 6, 2018

Conversation

3 participants
@kimallen
Contributor

kimallen commented Dec 5, 2018

Description

The automated upload (bin/upload-secure-migrations) applies the migration to all three environments: prod, staging, experimental. This adds instructions to secure migrations in database.md for how to run a migration only in staging (or chosen environment).

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@kimallen kimallen requested review from tinyels, stangah and chrisgilmerproj Dec 5, 2018

@tinyels

tinyels approved these changes Dec 5, 2018

* Check that it is NOT listed in the S3 production folder: `aws s3 ls s3://transcom-ppp-app-prod-us-west-2/secure-migrations/`
* Now upload empty files of the same name to the prod and experimental environments: `aws s3 cp --sse AES256 $YOUR_EMPTY_TMP_MIGRATION_FILE s3://transcom-ppp-app-prod-us-west-2/secure-migrations/`
* To verify upload and that the migration can be applied, temporarily change the S3 bucket to the staging bucket in the run-prod-migration file and then run `bin/run-prod-migrations`

This comment has been minimized.

@tinyels

tinyels Dec 5, 2018

Contributor

This looks good to me. If we end up doing this more often, we might want to augment the scripts to do some of the work for us, but that is probably gold-plating at the moment.

@chrisgilmerproj

🚀 - I love updated documentation! Nice going.

@kimallen kimallen merged commit d7f5fc5 into master Dec 6, 2018

9 checks passed

ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment