Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Kma 162678897 experiment set gex handler #1530
This creates a new environment variable that determines if a gex request should actually be sent or not. By default, the gex request will not be sent in local development, but will be sent in all deployed environments. The gex request now is found in an interface struct's function SendRequest. The actual request is stubbed by a call to a local server and utilizes that url instead of the gex url. Gex gex url is moved to a config var as GEX_URL.
This also now moves the environment variables accessed within the function that sends the gex request to parameters and passes them through a struct in the
Code Review Verification Steps
requested review from
Dec 29, 2018
left a comment
As far as testing goes, it's a hard question to answer in this situation. With the method params/signature, we'd want to test the various scenarios of what we can send to gex and what they would return. From my understanding though, they really just give us a
It does feel kind of empty though, like we're missing something. Maybe someone else has thoughts.