New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move building of chamber and soda in circleci to the makefile #1542

Merged
merged 5 commits into from Jan 4, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Jan 2, 2019

Description

Found some TODOs in the CircleCI config file. These were easy to pull out into separate targets to be used in by CircleCI.

Setup

This should work as usual:

make server_deps

But also try:

make clean build_chamber build_soda

Code Review Verification Steps

  • Request review from a member of a different team.

References

@chrisgilmerproj chrisgilmerproj self-assigned this Jan 2, 2019

@chrisgilmerproj chrisgilmerproj requested a review from pjdufour-truss Jan 2, 2019

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

chrisgilmerproj commented Jan 3, 2019

Deployed to experimental here: https://circleci.com/workflow-run/66f9f042-85c1-4a1a-a151-c5c7ab995ba8

screen shot 2019-01-03 at 3 57 44 pm

It worked! Will revert last commit.

@chrisgilmerproj chrisgilmerproj merged commit 9c32594 into master Jan 4, 2019

12 checks passed

ci/circleci: acceptance_tests Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_162931822_build_chamber_and_soda_separately branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment