New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code related with rejecting a shipment #1546

Merged
merged 1 commit into from Jan 3, 2019

Conversation

3 participants
@Ronolibert
Copy link
Contributor

Ronolibert commented Jan 3, 2019

Description

Removing the code related with rejecting a shipment because we do not want TSPs to reject a shipment.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

Screenshots

Does not have the Reject Shipment button anymore
image

@Ronolibert Ronolibert requested review from jim , chrisgilmerproj and kahlouie Jan 3, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

👍 - my only comment is that you should probably make a new Pivotal task in the backlog to put this back (when we do get around to rejection work) and reference this PR so it saves future "you" some time.

@kahlouie
Copy link
Contributor

kahlouie left a comment

:shipit:

@Ronolibert

This comment has been minimized.

Copy link
Contributor

Ronolibert commented Jan 3, 2019

@chrisgilmerproj Was going to do this, but turns out it already exists and you made it a while ago haha. Here is the card and I added a note in the description of this PR.

@Ronolibert Ronolibert merged commit 1b615bf into master Jan 3, 2019

12 checks passed

ci/circleci: acceptance_tests Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@Ronolibert Ronolibert deleted the roc-#162626768-remove-reject-shipment branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment