New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include an error message if the ppp-infra directory is not linked correctly #1553

Merged
merged 3 commits into from Jan 4, 2019

Conversation

3 participants
@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Jan 4, 2019

Description

Sometimes the transcom/ppp-infra repo location is either changed or not set and there is no error when calling direnv allow. This adds some text to help people figure out what's wrong.

Reviewer Notes

Is the message clear enough?

Setup

Change your PPP_INFRA_PATH location in .envrc.local and run direnv allow. The error should say:

direnv: loading .envrc
direnv: loading .envrc.local
direnv: Unable to find the transcom-ppp/.envrc file. Please check PPP_INFRA_PATH if aws commands don't work
direnv: export +AWS_PROFILE +AWS_S3_BUCKET_NAME +AWS_S3_KEY_NAMESPACE +AWS_S3_REGION +AWS_SES_DOMAIN +AWS_SES_REGION +CLIENT_AUTH_SECRET_KEY +CLIENT_TLS_CERT +CLIENT_TLS_KEY +CSRF_AUTH_KEY +DANGEROUSLY_DISABLE_HOST_CHECK +DB_HOST +DB_NAME +DB_PASSWORD +DB_PORT +DB_USER +DOD_CA_PACKAGE +DPS_AUTH_COOKIE_SECRET_KEY +DPS_AUTH_SECRET_KEY +DPS_COOKIE_EXPIRES_IN_MINUTES +DPS_COOKIE_NAME +DPS_REDIRECT_URL +GEX_BASIC_AUTH_PASSWORD +GEX_BASIC_AUTH_USERNAME +GEX_DOD_CA +HERE_MAPS_APP_CODE +HERE_MAPS_APP_ID +HERE_MAPS_GEOCODE_ENDPOINT +HERE_MAPS_ROUTING_ENDPOINT +HONEYCOMB_API_HOST +HONEYCOMB_API_KEY +HONEYCOMB_DATASET +HONEYCOMB_DEBUG +HONEYCOMB_ENABLED +HTTP_SDDC_PORT +HTTP_SDDC_PROTOCOL +IWS_RBS_HOST +LOGIN_GOV_CALLBACK_PORT +LOGIN_GOV_CALLBACK_PROTOCOL +LOGIN_GOV_HOSTNAME +LOGIN_GOV_MY_CLIENT_ID +LOGIN_GOV_OFFICE_CLIENT_ID +LOGIN_GOV_SECRET_KEY +LOGIN_GOV_TSP_CLIENT_ID +MOVE_MIL_DOD_CA_CERT +MOVE_MIL_DOD_TLS_CERT +MOVE_MIL_DOD_TLS_KEY +MYMOVE_DIR +NO_SESSION_TIMEOUT +PPP_INFRA_PATH +SECURE_MIGRATION_DIR +SECURE_MIGRATION_SOURCE +TZ

Code Review Verification Steps

  • Request review from a member of a different team.

@chrisgilmerproj chrisgilmerproj self-assigned this Jan 4, 2019

@chrisgilmerproj chrisgilmerproj requested review from lynzt and pjdufour-truss Jan 4, 2019

@lynzt

lynzt approved these changes Jan 4, 2019

Copy link
Contributor

lynzt left a comment

LGTM!

@chrisgilmerproj chrisgilmerproj merged commit afeda90 into master Jan 4, 2019

12 checks passed

ci/circleci: acceptance_tests Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_better_ppp_infra_envrc_error_msg branch Jan 4, 2019

@sarboc

This comment has been minimized.

Copy link
Contributor

sarboc commented Jan 7, 2019

This helped me fix my local dev env! 👍

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

chrisgilmerproj commented Jan 7, 2019

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment