New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructures Go tests to use BaseTestSuite and PopTestSuite #1557
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c9e6572
Restructures Go tests to use BaseTestSuite and PopTestSuite
stangah eb1b43f
Ports over remaining test suites that interact with db
stangah c1c3468
Pulls DB instantiation into PopTestSuite
stangah 810a052
Merge branch 'master' into ps-test-suite
stangah 42f8ec9
Fixes tests
stangah 814016e
Merge branch 'master' into ps-test-suite
stangah 84a5633
Merge branch 'master' into ps-test-suite
stangah File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like most of our test suites have a
*zap.Logger
, although we sometimes initialize it toNewDevelopment()
and other times toNewNop()
(not sure if that's intentional or not). Should we consider movinglogger
up to theBaseTestSuite
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to leave
BaseTestSuite
purposefully kind of plain and single focused. I thinklogger
is mostly used for passing into handler contexts and other child structs anyway, so I'm okay with leavinglogger
usage up to the test suite author