New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Deployed Commit #1559

Merged
merged 1 commit into from Jan 8, 2019

Conversation

2 participants
@pjdufour-truss
Copy link
Contributor

pjdufour-truss commented Jan 8, 2019

Description

Check that app service deployed the expected version of mymove, using the health endpoint.

Reviewer Notes

Is there anything you would like reviewers to give additional scrutiny?

Setup

Add any steps or code to run in this section to help others prepare to run your code:

./bin/check-deployed-commit my.experimental.move.mil,office.experimental.move.mil XYZ

Code Review Verification Steps

No go changes.

References

Screenshots

N.A.

@pjdufour-truss pjdufour-truss requested a review from chrisgilmerproj Jan 8, 2019

@pjdufour-truss pjdufour-truss force-pushed the check_health_commit branch from 8e079f5 to bb5deaa Jan 8, 2019

do
DEPLOYED_COMMIT=$(curl "https://${host}/health" | jq -r .gitCommit)
if [[ "$DEPLOYED_COMMIT" != "$TARGET_COMMIT" ]]; then
echo "On $host, found $DEPLOYED_COMMIT, expecting $TARGET_COMMIT."

This comment has been minimized.

@chrisgilmerproj

chrisgilmerproj Jan 8, 2019

Contributor

I suggest making this message a little more explicit. Perhaps On host $host the commit returned from the health check does not match what we expected to have deployed. Found: $DEPLOYED_COMMIT, Expected: $TARGET_COMMIT.

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

One fix and then this is good to go!

@pjdufour-truss pjdufour-truss force-pushed the check_health_commit branch from bb5deaa to 7386fb1 Jan 8, 2019

@pjdufour-truss pjdufour-truss merged commit f6f066e into master Jan 8, 2019

12 checks passed

ci/circleci: acceptance_tests Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@pjdufour-truss pjdufour-truss deleted the check_health_commit branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment