New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Air Force Orders certificate migration #1574

Merged
merged 2 commits into from Jan 9, 2019

Conversation

3 participants
@jamesatheyDDS
Copy link
Contributor

jamesatheyDDS commented Jan 9, 2019

I don't have the production certificate for the Air Force orders system yet, so this PR removes the migration. I will create a future PR with a new migration when the Air Force sends its public certificates to us.

@jamesatheyDDS jamesatheyDDS self-assigned this Jan 9, 2019

@jamesatheyDDS jamesatheyDDS requested a review from sarboc Jan 9, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

⭐️

@sarboc

sarboc approved these changes Jan 9, 2019

Copy link
Contributor

sarboc left a comment

👍
Tested by running bin/run-prod-migrations against both the staging and production s3 buckets. Both tests ran without issue.

@jamesatheyDDS jamesatheyDDS force-pushed the remove-air-force-cert-migration branch from 1d7abe9 to f2d72b8 Jan 9, 2019

@sarboc sarboc merged commit 2600512 into master Jan 9, 2019

12 checks passed

ci/circleci: acceptance_tests Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@sarboc sarboc deleted the remove-air-force-cert-migration branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment